Fix multiple issues with MSVC Windows build #178
Merged
+91
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twogood
reviewed
Dec 26, 2023
|
Thank you @elasota and Happy New Year! |
bwrsandman
reviewed
Jan 3, 2024
| @@ -25,6 +25,7 @@ if(BUILD_STATIC) | |||
| add_library(libunshield STATIC ${LIBUNSHIELD_HEADERS} ${LIBUNSHIELD_SOURCES}) | |||
| else() | |||
| add_library(libunshield SHARED ${LIBUNSHIELD_HEADERS} ${LIBUNSHIELD_SOURCES}) | |||
| add_compile_definitions(LIBUNSHIELD_DYNAMIC_LIBRARY) | |||
There was a problem hiding this comment.
If this isn't a private target definition it might leak and cause clients to define it and use dllexport
| @@ -16,6 +16,12 @@ | |||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| #if defined(_MSC_VER) && defined(LIBUNSHIELD_DYNAMIC_LIBRARY) | |||
| #define UNSHIELD_DLLEXPORT __declspec(dllexport) | |||
There was a problem hiding this comment.
You get better optimization if you define it as dllimport for clients
|
Thanks @bwrsandman , looks like we might need a new PR to improve this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several problems with MSVC build and Windows:
staton the drive, which doesn't work, then attempting to call_mkdirfor the drive, which also doesn't work